fix: update module resolution for non-relative paths#229
fix: update module resolution for non-relative paths#229mrmckeb merged 1 commit intomrmckeb:mainfrom
Conversation
|
Hey @mrmckeb! I imagine you've got a ton of other stuff going on, but let me know if you have a chance to take a look at this any time soon! I'd love to get your thoughts. Thanks so much for all of your work on this plugin! |
|
Any updates? |
|
Hey @mrmckeb! I just wanted to check in and see whether you might have a chance to take a look at this PR sometime soon! |
mrmckeb
left a comment
There was a problem hiding this comment.
Thanks @smoores-dev - this looks great to me. Sorry for the very slow turnaround, I try to check in once every 2-3 weeks (unless there's a critical issue) but had a bit more going on recently.
|
Closing and reopening to trigger tests, etc. |
|
I plan to get this out in the next day or two - I also need to set up automatic releases for this repo. |
|
Sorry this took so long. Released: |
Fixes #227.
This change generalizes "module resolution with failed lookup locations" so that it works for newer implementations of the typescript language server, which provide such information in the response for
resolveModuleNameLiterals, rather than implementing a separategetResolvedModuleWithFailedLookupLocationsFromCache.Tested locally in a project using Typescript 5 and path aliases, and imports like:
which were failing before this change now successfully show type information and support "Go to Definition", etc.