Pipe not Working

[adam-grant-hendry]

Description

First discovered in MinGW bug report #2303, pipes seem to fail in certain circumstances in the bash that ships with Git for Windows:

Example 1

$ x=$(echo a | grep a)
$ echo a=$x

Expected Output: a=a
Actual Output: a=

error_01.mp4

Example 2

For reference, please see commitizen PR #605

$ poetry run python -m pydocstyle --convention=google --add-ignore=D1,D415 --match-dir='^(?![.]|venv).*'

Expected Output: Runs and passes (no output)
Actual Output: 'venv).*' is not recognized as an internal or external command, operable program or batch file.

$ poetry run python -m pydocstyle --convention=google --add-ignore=D1,D415 --match-dir="^(?![.]|venv).*"

Expected Output: Runs and passes (no output)
Actual Output: bash: ![.]: event not found

error_02.mp4

Verification

• I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

OS: determined with cmd.exe /c ver

Microsoft Windows [Version 10.0.19044.2006]

Git: determined with git --version

git version 2.36.1.windows.1

Bash: determined with uname:

kernel-name: MINGW64_NT-10.0-19044
kernel-release: 3.3.4-341.x86_64
kernel-version: 2022-05-09 11:56 UTC
machine: x86-64
operating-system: Msys

MINGW environments affected

• MINGW64
• MINGW32
• UCRT64
• CLANG64
• CLANG32
• CLANGARM64

Expected behavior

Please see details in Description.

Actual behavior

Please see details in Description.

Repro steps

Please see details in Description.

Are you willing to submit a PR?

If I know how to fix it, yes.

[sskras]

On my machine it works:

My version looks 2 months later:

kernel-name: MINGW64_NT-10.0-19044
kernel-release: 3.3.5-341.x86_64
kernel-version: 2022-07-04 21:33 UTC
machine: x86-64
operating-system: Msys

[adam-grant-hendry]

@sskras Thank you for the quick reply!

Interesting...I also see this on my CI in GitHub Actions with windows-latest (i.e. Windows Server 2022), so git probably needs an update.

On my local machine, I updated Git to 2.36.1.windows.1 -> 2.38.1.windows.1 and can confirm Example #1 works, but Example #2 is still failing:

error_03.mp4

Is there a command that accepts a regex as a string we could test so I can narrow down whether the issue is with MinGW or the repo?

[jeremyd2019]

x=$(echo a | grep -E 'a|b')
echo x=$x

? I suspect poetry run is not properly handling quoting/escaping somehow (maybe it's trying to use CMD rules for bash or vice-versa)

[adam-grant-hendry]

x=$(echo a | grep -E 'a|b')
echo x=$x

Ya, I can confirm the above works for me as expected.

maybe it's trying to use CMD rules for bash or vice-versa

That's funny, I was thinking the exact same thing. If you run

$ poetry run python -m pydocstyle --convention=google --add-ignore=D1,D415 --match-dir='^(?![.]|venv).*'

in Command Prompt, you'll get the same error

'venv).*' is not recognized as an internal or external command, operable program or batch file.

but if you switch it with double-quotes it works, whereas Git Bash is outputting the strange error

bash: ![.]: event not found

When I first came across this issue, I was thinking it was a Command Prompt-related issue, which is why I tried switching to double-quotes.

[adam-grant-hendry]

It's definitely reading the ! as history expansion, but if you turn it off with set +H, you get the original error:

'venv).*' is not recognized as an internal or external command, operable program or batch file.

so definitely something parsing-wise is going on...

[adam-grant-hendry]

Since GitHub Discussions doesn't link, here is the question I posted on the poetry repo: python-poetry/poetry Discussion #6856.

Glad updating MinGW solved the first problem. For the second, I'm leaning toward this being an issue on poetry's end (particularly as I specify the bash shell in my CI scripts; not sure if that implies MinGW/Git Bash are run or a WSL variant as I've never used Windows Server 2022 locally).

Feel free to close and I can re-open if it turns out to be a MinGW problem.