fix: untangle pkg and core#5896
Merged
Merged
Conversation
… and IS USED in pkg Signed-off-by: Dave Lee <dave@gray101.com>
…it, but it does reference core. Signed-off-by: Dave Lee <dave@gray101.com>
Signed-off-by: Dave Lee <dave@gray101.com>
…ble dependencies on core Signed-off-by: Dave Lee <dave@gray101.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
approved these changes
Jul 24, 2025
mudler
left a comment
mudler
left a comment
Owner
There was a problem hiding this comment.
Thanks! good point, I like the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past we had I thought we had decided that it would be ideal if
corereferencedpkgbut not the other way around.core/system was used from pkg, but has no dependencies on core itself
pkg/templates and pkg/startup were using core from within pkg
Not super related: happened to notice a duplicative check in cli util