fix(reranker): respect top_n in the request#7025
Merged
mudler merged 4 commits intomudler:masterfrom Nov 6, 2025
Merged
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
61ee6b4 to
51d6347
Compare
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
Contributor
Author
|
presumably it might be fixed for llama_cpp rerank as well, if @mudler consider it necessary. |
Owner
|
Hey, thanks for looking at this!
I think for llama.cpp we should be covered already, as top_k/top_p settings are already propagated for the chat (and rerankers follows along the same reasoning): LocalAI/backend/cpp/llama-cpp/grpc-server.cpp Line 104 in 2573102 Unless you noticed something off! |
mudler
approved these changes
Nov 6, 2025
top_n in the request
This was referenced Nov 7, 2025
Contributor
Author
|
I just realized that the most users don't pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6700
Notes for Reviewers
Signed commits