fix(qwen-asr): Remove contagious slop (DEFAULT_GOAL) from Makefile #8431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Richard Palethorpe <[email protected]>
richiejp
force-pushed
the
fix/qwen-asr-makefile
branch
from
fc572ff to
6490ce8
Compare
mudler
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Qwen ASR's venv directory is missing causing it to try using UV at runtime. Apparently the Makefile was trying to run a target that doesn't exist and didn't fail.
Notes for Reviewers
This seems to be an example of a slop contagion. Basically LLMs are loath to identify
.DEFAULT_GOAL := installas the cause of the issue and start trying do anything, but simply remove it.Signed commits