[test] Testing react 16.9 release candidate

[eps1lon]

Testing release candidate (new runtime warnings, act warnings, useEffect + setState)

react changelog draft

Bundle size changes are likely due to react-is and scheduler changes. We should mark every dependency of react and react-dom as external when calculating bundle size. This includes scheduler. Not sure about react-is. Likely react-is. Scheduler isn't is as per #16904

[mui-pr-bot]

Details of bundle changes.

Comparing: ba2b44c...f21b726

bundle	parsed diff	gzip diff	prev parsed	current parsed	prev gzip	current gzip
@material-ui/core	+0.05% 🔺	+0.09% 🔺	329,663	329,833	90,121	90,198
@material-ui/core/Paper	+0.25% 🔺	+0.25% 🔺	68,684	68,854	20,469	20,520
@material-ui/core/Paper.esm	+0.27% 🔺	+0.24% 🔺	62,058	62,228	19,209	19,255
@material-ui/core/Popper	0.00%	0.00%	29,185	29,185	10,434	10,434
@material-ui/core/Textarea	0.00%	0.00%	5,759	5,759	2,368	2,368
@material-ui/core/TrapFocus	0.00%	0.00%	3,834	3,834	1,617	1,617
@material-ui/core/styles/createMuiTheme	0.00%	0.00%	16,389	16,389	5,824	5,824
@material-ui/core/useMediaQuery	0.00%	0.00%	3,213	3,213	1,311	1,311
@material-ui/lab	+0.11% 🔺	+0.10% 🔺	152,607	152,777	46,520	46,568
@material-ui/styles	+0.33% 🔺	+0.35% 🔺	51,401	51,571	15,285	15,338
@material-ui/system	0.00%	0.00%	15,666	15,666	4,350	4,350
Button	+0.21% 🔺	+0.20% 🔺	79,421	79,591	24,279	24,327
Modal	0.00%	0.00%	15,050	15,050	5,233	5,233
Portal	0.00%	0.00%	3,579	3,579	1,568	1,568
Rating	+0.24% 🔺	+0.24% 🔺	70,735	70,905	22,079	22,132
Slider	+0.23% 🔺	+0.21% 🔺	75,066	75,236	23,271	23,320
colorManipulator	0.00%	0.00%	3,904	3,904	1,543	1,543
docs.landing	0.00%	0.00%	52,124	52,124	13,837	13,837
docs.main	+1.29% 🔺	+1.25% 🔺	590,550	598,182	188,602	190,967
packages/material-ui/build/umd/material-ui.production.min.js	+0.06% 🔺	+0.05% 🔺	299,964	300,129	86,137	86,184

Generated by 🚫 dangerJS against f21b726

[oliviertassinari]

@eps1lon It's continuous integration is green :). Should we expect more than it from the pull request?

[eps1lon]

Should we expect more than it from the pull request?

Testing release candidate (new runtime warnings, act warnings, useEffect + setState)

Could you actively engage in communicating what you want from this PR?

[oliviertassinari]

From what I understand, the value of the pull request is to test the release candidate of React v16.9.0, to detect potential issues ahead of time, before our users do. Now that it's green, we are good. I believe that we can close it. Then, Dependabot will take care of updating the dependency for us. Have I missed a step in the reasoning?

[eps1lon]

Have I missed a step in the reasoning?

Yes: React isn't release yet. There might be another rc. It's the same reason I didn't close it after the canary was green.

Edit: And then there's the issue of development happening on master which we might want to check against 16.9.

[oliviertassinari]

Ok, awesome!