[material-ui][docs] Open Material UI template with CodeSandbox/StackBlitz#43604
[material-ui][docs] Open Material UI template with CodeSandbox/StackBlitz#43604siriwatknp merged 43 commits intomui:masterfrom
Conversation
Netlify deploy preview
Bundle size report |
| - run: | ||
| name: Update the templates shared themes | ||
| command: pnpm template:update-theme | ||
| - run: | ||
| name: '`pnpm template:update-theme` changes committed?' | ||
| command: git add -A && git diff --exit-code --staged |
There was a problem hiding this comment.
No longer need to run the script. The shared theme is the source of truth and it will be bundled with the template when users open CodeSandbox or StackBlitz.
5d2c232 to
20cfc8e
Compare
|
Hey @siriwatknp I've added a couple tweaks to the One thing that I think we still need to fix is the template screenshot script. I reckon the toolbar shouldn't be included on those, is it possible? The script is I really like the content of the contributing guide, but its placement on this page feels a bit off. The page is already packed with templates, a Store CTA for premium templates, and Toolpad Core, so adding the guide there might be a bit confusing. How about adding it as a FAQ item like, 'How can I contribute to the free templates?' with a link on the templates page? |
…i into poc/template-theme
Done! |
oliviertassinari
left a comment
There was a problem hiding this comment.
Cool banner, but it looks like we need to continue to iterate on this:
- Doesn't work on mobile:
Screen.Recording.2024-09-22.at.00.02.25.mov
- Can't really click on it:
Screen.Recording.2024-09-22.at.00.04.33.mov
|
@oliviertassinari sure thing! We're still iterating it on #43708 |





Iterate on #41469
Preview: https://deploy-preview-43604--material-ui.netlify.app/material-ui/getting-started/templates/sign-in/
Preview: https://deploy-preview-43604--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/
Changes
All of the changes are done for
SignInandDashboardtemplates only (once this PR is merged, I will open another PR to apply to the rest of the templates).theme.vars.TemplateFrame.jsso that the template code is clean and ready to be used.TemplateFrame Toolbar