Skip to content

[slider][docs] Polish Music player demo#43748

Merged
oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari:slider-docs-polish
Sep 15, 2024
Merged

[slider][docs] Polish Music player demo#43748
oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari:slider-docs-polish

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 13, 2024

A quick polish on #43743. I thought this would look better and be denser, using less vertical space:

Before
SCR-20240913-rjpk

After
SCR-20240913-rjmt

This docs option is not used so often on Material UI. We use it a lot with the MUI X Data Grid though, e.g. https://mui.com/x/react-data-grid/#mit-license-free-forever

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. scope: slider Changes related to the slider. labels Sep 13, 2024
@mui-bot
Copy link

mui-bot commented Sep 13, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6acf57f

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! TIL about bg: inline.

I'll take a look and see if we can get rid of the top margin of the bottom bar when bg: inline is present, but maybe other demos need it, not sure.

Screenshot 2024-09-14 at 20 35 30

Also, it'd be nice that the demo follows the border radius of the container:

Screenshot 2024-09-14 at 20 33 59

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 14, 2024

maybe other demos need it, not sure.

For the data grid demos linked in the PR description, I doubt it would work without 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: slider Changes related to the slider.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants