[system] Add empty interfaces to fix issue with typescript module augmentation #43873
Merged
mnajdova merged 5 commits intomui:masterfrom Oct 3, 2024
Merged
[system] Add empty interfaces to fix issue with typescript module augmentation #43873mnajdova merged 5 commits intomui:masterfrom
mnajdova merged 5 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-43873--material-ui.netlify.app/ Bundle size report |
Janpot
added
scope: system
Janpot
changed the title
Janpot
approved these changes
Sep 24, 2024
Janpot
reviewed
Sep 24, 2024
| typography?: unknown; | ||
| mixins?: Mixins; | ||
| typography?: Typography; | ||
| zIndex?: unknown; |
Member
There was a problem hiding this comment.
The only unknown left is zIndex. Is there a reason not to type it the same way as ThemeOptions?
Contributor
Author
|
Contributor
Author
|
hey @Janpot, |
Janpot
approved these changes
Sep 25, 2024
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
This seems good to me
maybe you have some insights for me on how to fix this?
This screenshot is flaky, we haven't fully figured out why yet. You can safely ignore
mnajdova
approved these changes
Oct 3, 2024
Member
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
It's a great first conutrion on MUI 👌 People will appreciate the fix! :)
This was referenced Oct 31, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43855