Skip to content

[core] Add remove-proptypes markers to generated propTypes - #22850

Merged
JCQuintas merged 1 commit into
mui:masterfrom
JCQuintas:add-remove-proptypes-markers
Jun 17, 2026
Merged

JCQuintas merged 1 commit into
mui:masterfrom
JCQuintas:add-remove-proptypes-markers

Conversation

@JCQuintas

Copy link
Copy Markdown
Member

Side effect of regenerating propTypes after #22750 (strip propTypes from production bundles).

The /* remove-proptypes */ marker lets the babel plugin strip these propTypes blocks from production bundles. Regenerating propTypes after #22750 emitted the markers across all packages.

Side effect of regenerating propTypes after mui#22750 (strip propTypes from production bundles). The marker enables the babel plugin to remove these blocks from prod builds.
@JCQuintas
JCQuintas requested a review from alexfauquette as a code owner June 17, 2026 09:25
@JCQuintas JCQuintas self-assigned this Jun 17, 2026
@JCQuintas JCQuintas added internal Behind-the-scenes enhancement. Formerly called “core”. type: bug It doesn't behave as expected. labels Jun 17, 2026
@JCQuintas
JCQuintas enabled auto-merge (squash) June 17, 2026 09:28
@code-infra-dashboard

code-infra-dashboard Bot commented Jun 17, 2026 •

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-22850--material-ui-x.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)
@mui/x-license 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

ℹ️ Using benchmark from parent commit cd9e496 (fallback from merge base 12b2b7c).

Total duration: 2,019.61 ms +90.13 ms(+4.7%) | Renders: 67 (+0)

Test Duration Renders
Area chart with big data amount (no marks) 25.72 ms 🔺+4.77 ms(+22.8%) 2 (+0)
SankeyChart with big data amount 11.09 ms 🔺+2.42 ms(+28.0%) 2 (+0)
ScatterChartPro with big data amount and zoomed in (single renderer) 11.17 ms 🔺+2.38 ms(+27.1%) 2 (+0)
ScatterChartPro with big data amount and zoomed in (batch renderer) 10.33 ms 🔺+1.80 ms(+21.1%) 2 (+0)

22 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@JCQuintas
JCQuintas disabled auto-merge June 17, 2026 09:46
@JCQuintas
JCQuintas merged commit 4136ec3 into mui:master Jun 17, 2026
20 of 24 checks passed
@JCQuintas
JCQuintas deleted the add-remove-proptypes-markers branch June 17, 2026 09:46
mbrookes pushed a commit to mbrookes/mui-x that referenced this pull request Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants