Repository navigation
[core] Ignore code-infra-renovate[bot] commits in changelog - #23153
Merged
Merged
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
Janpot
added
type: regression
Janpot
marked this pull request as ready for review
July 15, 2026 13:31
brijeshb42
approved these changes
Jul 15, 2026
Member
|
This change would have been irrelevant after #23112, where deps PR filtering is based on labels ("dependencies" excluded). |
LukasTy
added a commit
to LukasTy/mui-x
that referenced
this pull request
Jul 15, 2026
…5ffb Reconcile with mui#23153: keep its IGNORED_BOT_LOGINS set (used by getContributors for attribution), but drop the author filter it added on the commit stream. This branch already excludes dependency bumps via the fixed `dependencies` label check, which covers every Renovate PR and survives future bot renames, so the author filter is redundant. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog script guarded against the renovate bots inconsistently:
getContributorsexcluded bothrenovate[bot]andcode-infra-renovate[bot](added in [code-infra] Add infra bot toifcondition #22951).renovate[bot](narrowed in [code-infra] Only ignore renovate[bot] in changelog generation script #21185).As a result,
code-infra-renovate[bot]commits (e.g. dependency bumps like #23121) still showed up as changelog entries while being excluded from contributor attribution.This extracts a shared
IGNORED_BOT_LOGINSset used by both guards so they can't drift again, and treatscode-infra-renovate[bot]the same asrenovate[bot]— excluded from the changelog entirely.