Repository navigation
[release] v9.10.0 - #23158
Merged
Merged
[release] v9.10.0#23158
Conversation
noraleonte
requested review from
a team,
JCQuintas,
alexfauquette and
romgrk
as code owners
July 16, 2026 14:41
JCQuintas
reviewed
Jul 16, 2026
Comment on lines
+49
to
+53
| - [charts] Provide `dataIndex` in `LinePlot` and `AreaPlot` onItemClick (#23144) @JCQuintas | ||
|
|
||
| `LinePlot` and `AreaPlot` `onItemClick` (and `LineChart`'s `onLineClick`/`onAreaClick`) now provide the `dataIndex` of the closest data point to the click. | ||
|
|
||
| The identifier passed to `LinePlot`, `AreaPlot`, and `MarkPlot` `onItemClick` is now typed as the new `LineItemClickIdentifier`, where `dataIndex` is required. The callback is no longer fired in the pathological case where no data point can be resolved from the click position. |
Member
There was a problem hiding this comment.
Suggested change
| - [charts] Provide `dataIndex` in `LinePlot` and `AreaPlot` onItemClick (#23144) @JCQuintas | |
| `LinePlot` and `AreaPlot` `onItemClick` (and `LineChart`'s `onLineClick`/`onAreaClick`) now provide the `dataIndex` of the closest data point to the click. | |
| The identifier passed to `LinePlot`, `AreaPlot`, and `MarkPlot` `onItemClick` is now typed as the new `LineItemClickIdentifier`, where `dataIndex` is required. The callback is no longer fired in the pathological case where no data point can be resolved from the click position. | |
| - [charts] Provide `dataIndex` in `LinePlot` and `AreaPlot` `onItemClick` (#23144) @JCQuintas |
Member
There was a problem hiding this comment.
maybe we should move that explanatory section to the highlights? WDYT @JCQuintas?
Deploy previewBundle size
PerformanceTotal duration: 1,653.66 ms +53.62 ms(+3.4%) | Renders: 63 (+0) | Paint: 2,268.55 ms +29.21 ms(+1.3%)
…and 9 more (+12 within noise) — details Metric alarms
…and 6 more metric alarms — details Check out the code infra dashboard for more information about this PR. |
arminmeh
reviewed
Jul 16, 2026
LukasTy
reviewed
Jul 17, 2026
michelengelen
approved these changes
Jul 17, 2026
michelengelen
left a comment
Member
There was a problem hiding this comment.
I have nothing to add. LGTM when the other review comments are resolved.
Comment on lines
+49
to
+53
| - [charts] Provide `dataIndex` in `LinePlot` and `AreaPlot` onItemClick (#23144) @JCQuintas | ||
|
|
||
| `LinePlot` and `AreaPlot` `onItemClick` (and `LineChart`'s `onLineClick`/`onAreaClick`) now provide the `dataIndex` of the closest data point to the click. | ||
|
|
||
| The identifier passed to `LinePlot`, `AreaPlot`, and `MarkPlot` `onItemClick` is now typed as the new `LineItemClickIdentifier`, where `dataIndex` is required. The callback is no longer fired in the pathological case where no data point can be resolved from the click position. |
Member
There was a problem hiding this comment.
maybe we should move that explanatory section to the highlights? WDYT @JCQuintas?
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
JCQuintas
approved these changes
Jul 17, 2026
LukasTy
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release version 9.10.0
Prepare the release of the packages
Release the packages
Publish the documentation
pnpm docs:deployPublish GitHub release
Announce