Repository navigation
[DateRangePicker] Fix broken active range position underline in single input range fields - #23201
Merged
Merged
Conversation
…e input range fields (mui#23166) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
LukasTy
added
cherry-pick
|
Deploy preview: https://deploy-preview-23201--material-ui-x.netlify.app/ Bundle size report
|
LukasTy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #23166
Done manually: the automated cherry-pick could not run for that PR. The
pull_request_targetrun failed on the newactions/checkoutv7 fork guard (since fixed in mui/mui-public#1694), and that event cannot be replayed, so the workflow could not produce this PR.Adaptations for v8.x
The source fix applied cleanly. The test file needed two adjustments, since v8.x predates some master-only changes:
openPicker(user, params)on master isopenPickerAsync(user, params)on v8.x (v8.x'sopenPickeris synchronous and takes nouser).enableAccessibleFieldDOMStructure: trueis passed explicitly, since v8.x still supports the non-accessible DOM structure, in which the active bar does not render.Verified on this branch: TypeScript, ESLint and Prettier all pass.