Repository navigation
[DataGridPremium] Refine cell selection and speed up clipboard copy - #23473
Merged
michelengelen merged 8 commits intoSep 2, 2026
Merged
Conversation
Signed-off-by: michel <jsnerdic@gmail.com>
Signed-off-by: michel <jsnerdic@gmail.com>
Signed-off-by: michel <jsnerdic@gmail.com>
…elected cells Signed-off-by: michel <jsnerdic@gmail.com>
Signed-off-by: michel <jsnerdic@gmail.com>
michelengelen
added
scope: data grid
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
MBilalShafi
approved these changes
Sep 2, 2026
MBilalShafi
left a comment
MBilalShafi
left a comment
Member
There was a problem hiding this comment.
All three points from my review on #23415 are addressed, plus the selectCellRange note and the footer judgement call — and each one comes with a test. Thanks for the quick follow-up 💙
Here's the verified fix before/after:
Steps: 1. Click cell (0, currencyPair) → 2. Press Ctrl+A → 3. Press Ctrl+C, watch the status box.
| row 0 fields in the model | first copied line | Ctrl+C (sandbox, dev build) | Ctrl+C (prod test build, 3 runs) | |
|---|---|---|---|---|
| after (this PR) | id, currencyPair, price1M |
"0\tPAIR0\t0" |
~635 ms | 84–92 ms |
| before (master) | __reorder__, id, currencyPair, price1M |
"\t0\tPAIR0\t0" (leading tab) |
~4.4 s | 3.36–3.53 s |
At 20k rows it's ~460–550 ms → ~37 ms. Both sides produce byte-identical output on this path (50k: 1,116,668 chars, 50,000 lines) — so on my machine the copy speedup is even bigger than the 10.7× in the description 👍
Added a couple minor comments. Apart from them, it LGTM.
… selection Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DJ8KnNjYytPyphsPxMBno6
michelengelen
enabled auto-merge (squash)
September 2, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23415. Addresses the review comments in this review.
Ctrl+Ano longer selects cells of the row reordering column.Ctrl+Ano longer selects skeleton rows from lazy loading or aggregation footer rows.selectCellRangenow uses the same column filter asCtrl+A. Ranges from Shift+click, drag, or the API skip the checkbox, detail panel, reorder, and actions columns.Note:
selectCellRangeis a public API method. Ranges that span utility columns now produce a model without those cells.Benchmark (median from 2 separate runs) with 50,000 rows and 200,000 selected cells (
Ctrl+A, then copy):Both copy paths produce identical output.