Repository navigation
[DataGrid][docs] Fix "Apply filters on demand" demo - #23602
Merged
JCQuintas merged 1 commit intoSep 17, 2026
Merged
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
michelengelen
added
type: bug
JCQuintas
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23495
The "Apply filters on demand" demo initialized its draft filter model by calling
gridFilterModelSelector(apiRef)inside theuseStateinitializer. This readsapiRef.currentduring render, which triggers the React warning reported in the issue.The demo now reads the active filter model with
useGridSelectorand uses that value to initialize the local draft. The existing behavior is preserved: opening the panel initializes the draft from the active model, clicking Apply updates the grid, and closing the panel discards unapplied changes.The generated JavaScript demo was updated with
pnpm docs:typescript:formatted.Changelog
Fix the "Apply filters on demand" demo accessing the grid API ref during render.
I have followed (at least) the PR section of the contributing guide.