Repository navigation
Conversation
With the `height` prop, the root used `flex: 1 0 auto`. In a flex row parent, flex-shrink: 0 keeps the root at its content width, so the grid overflows a parent that is narrower than its columns. The root now uses `flex: 1`, and `minHeight` with `maxHeight` hold the height instead. This also fixes the flaky HeightGrid screenshot. The grid overflowed the 500px centered regression box and sat at a half pixel (x = -100.5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…parents without a height Point users who need a responsive height to a CSS variable, since `sx` height overrides lose to the min and max height the prop sets. Remove the sx override test that contradicts the docs, and cover a flex column parent without a height, where min-height alone holds the height.
JCQuintas
added
docs
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #23745. Only the last commit (11a3ff6) is new; the other commits come from #23745.
sxheight override loses to theminHeightandmaxHeightthat the prop sets, so pass a CSS variable to the prop and set the variable withsxbreakpoints.minHeighttogether withheight, which the docs now tell users not to rely on.flex: 1(basis0%),min-heightalone holds the height there. The new test fails when the root usesminHeight: 0.