Repository navigation
[code-infra] Wait for data-screenshot-pending before regression screenshots - #23772
Merged
Merged
Conversation
TailwindDemoContainer shows a spinner until the Tailwind script loads from the network, which made TailwindChatDemo flaky. It now marks the spinner with data-screenshot-pending, and navigateToTest waits until no such marker is left in the test case. Any demo can use it while it loads something the timer flush doesn't cover. This replaces the GridToolbarCustom rule.
Replaces the map-images-ready sentinel and its two route rules, and the 1x1 visible-div workaround it needed.
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
The test case rendered aria-busy until it mounted and fonts loaded. It now renders a hidden data-screenshot-pending child instead, so the runner checks one condition and aria-busy isn't used as a test signal.
LukasTy
added
test
type: enhancement
Janpot
marked this pull request as ready for review
October 5, 2026 14:08
Janpot
enabled auto-merge (squash)
October 5, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23748.
TailwindChatDemosometimes got captured as a spinner:TailwindDemoContainerloads Tailwind from the network, and the regression runner only waits for fonts and fake timers.data-screenshot-pendingwhile they load something the timer flush doesn't cover.navigateToTestwaits until none is left.TailwindDemoContainersets it on its spinner. This replaces theGridToolbarCustomrule.map-images-readysentinel and two rules.aria-busyon the test case. The runner checks one condition::not(:has([data-screenshot-pending])).aria-busyisn't used for this: chat messages and the tree view set it on purpose while streaming or lazy loading.