Repository navigation
[DataGridPro] Skip the infinite loader when IntersectionObserver is unavailable - #23869
Merged
michelengelen merged 2 commits intoOct 14, 2026
Conversation
michelengelen
added
type: bug
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
arminmeh
approved these changes
Oct 14, 2026
…er/useGridInfiniteLoadingIntersection.tsx Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
michelengelen
enabled auto-merge (squash)
October 14, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The infinite loading hook creates an
IntersectionObserverwith no check that the API exists. jsdom does not implementIntersectionObserver, so any Jest or Vitest test that rendersDataGridProorDataGridPremiumwithonRowsScrollEndorlazyLoadingcrashes withIntersectionObserver is not defined. The hook now checks thatIntersectionObserveris defined before it creates the observer, in the same way as the Material UITabscomponent. When the API is not available, the grid renders as usual, and scroll-end loading does not start. Behavior in browsers does not change.A new test removes
IntersectionObserverwithvi.stubGlobaland renders the grid. Unlike the other infinite loader tests, this test also runs in jsdom.Fixes #12983