Skip to content

[charts] Fix aria role on popper - #23939

Merged
noraleonte merged 2 commits into
mui:masterfrom
noraleonte:charts/fix-popper-aria-role
Oct 20, 2026
Merged

noraleonte merged 2 commits into
mui:masterfrom
noraleonte:charts/fix-popper-aria-role

Conversation

@noraleonte

Copy link
Copy Markdown
Contributor

follow-up on #23878

@noraleonte
noraleonte requested a review from JCQuintas October 19, 2026 19:16
@noraleonte noraleonte added accessibility a11y type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Oct 19, 2026
@code-infra-dashboard

code-infra-dashboard Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-23939--material-ui-x.netlify.app/
QR code for https://deploy-preview-23939--material-ui-x.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+21B(0.00%) 🔺+9B(+0.01%)
@mui/x-charts-premium 🔺+21B(0.00%) 🔺+8B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)
@mui/x-scheduler 0B(0.00%) 0B(0.00%)
@mui/x-scheduler-premium 0B(0.00%) 0B(0.00%)
@mui/x-chat 0B(0.00%) 0B(0.00%)
@mui/x-license 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,666.35 ms +184.13 ms(+12.4%) | Renders: 63 (+0) | Paint: 2,325.27 ms +272.76 ms(+13.3%)

Test Duration Renders
SparkLineChart grid of 100 instances 244.39 ms 🔺+158.91 ms(+185.9%) 1 (+0)
BarChartPro with big data amount 40.96 ms 🔺+10.96 ms(+36.6%) 2 (+0)
LineChartPro with big data amount and zoomed in (with marks) 27.55 ms 🔺+9.19 ms(+50.1%) 2 (+0)
FunnelChart with big data amount 6.18 ms 🔺+1.09 ms(+21.3%) 2 (+0)
RadarChart with many axes and multiple series 17.84 ms ▼-6.07 ms(-25.4%) 2 (+0)

21 tests within noise — details

Metric alarms

Test Metric Change
SparkLineChart grid of 100 instances bench:paint 🔺 +253.89 ms
BarChartPro with big data amount bench:paint 🔺 +14.32 ms
LineChartPro with big data amount and zoomed in (with marks) bench:paint 🔺 +13.15 ms
FunnelChart with big data amount bench:paint 🔺 +1.92 ms

Check out the code infra dashboard for more information about this PR.

@noraleonte
noraleonte merged commit 982dd7f into mui:master Oct 20, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility a11y scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants