Repository navigation
[scheduler] Add utility classes to the dependency UI - #24035
Merged
rita-codes merged 12 commits intoOct 29, 2026
Merged
rita-codes merged 12 commits into
rita-codes merged 12 commits into
Conversation
…alog like the event dialog
…ead the dialog classes from one context
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
rita-codes
added
the
type: enhancement
rita-codes
changed the title
…m the event dialog
… dialog's styled component
rita-codes
marked this pull request as ready for review
October 28, 2026 17:29
…orm and actions on the shared dialog styles
…rify the form class and header comment
flaviendelangle
approved these changes
Oct 29, 2026
flaviendelangle
left a comment
flaviendelangle
left a comment
Member
There was a problem hiding this comment.
PR review
No findings. No merge-blocking issues found in the diff against GitHub’s base commit.
The dependency arrow, terminal, and editor suites passed: 155 tests passed, 27 skipped. Browser-only behavior and visual layout were not verified.
Already tracked
- Dependency UI localization is handled in #24027.
- Public dependency props, exports, and documentation are tracked in #23420.
- Omitting classes for the invisible anchor and interaction layer is explicitly accepted in the PR scope.
Verdict
Approve - no actionable regressions or correctness issues found.
🤖 Review generated with Codex
github-actions
Bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ependencies-utility-classes # Conflicts: # packages/x-scheduler/src/internals/components/event-editing/FormContent.tsx
github-actions
Bot
removed
the
PR: out-of-date
…ependencies-utility-classes # Conflicts: # packages/x-scheduler-premium/src/event-timeline-premium/content/timeline-dependencies/dependency-dialog/DependencyDialogDetails.tsx # packages/x-scheduler-premium/src/event-timeline-premium/content/timeline-dependencies/dependency-dialog/DependencyDialogFormContent.tsx # packages/x-scheduler-premium/src/event-timeline-premium/content/timeline-dependencies/dependency-dialog/DependencyDialogReadonlyContent.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24023. Part of #23420.
What
dependencyArrows,dependencyTerminals,eventDependencyTerminaldependencyDialog,dependencyDialogPaper,dependencyDialogHeader,dependencyDialogTitle,dependencyDialogCloseButton,dependencyDialogContent,dependencyDialogForm(the form, or the details section when read-only),dependencyDialogBody,dependencyDialogDetails,dependencyDialogEventChip,dependencyDialogLag,dependencyDialogLagUnit,dependencyDialogLagNote(read-only dialog only; in the form the note is the lag field's helper text),dependencyDialogDivider,dependencyDialogActionsx-scheduler/src/internals/constants/dialogStyles.tsholds the base styles of the dialog parts (no slot, no class). Each dialog spreads them into its own styled components.useDraggableAnchoredPaperholds the paper's positioning next to its anchor and the drag. Both dialog papers use it.TODO(dependencies public flip, #23420)markers about classes and width. The localeText ones are handled in [scheduler-premium] Move the dependency UI strings tolocaleText#24027.EventDialogRoot,EventDialogDraggablePaper,EventDialogHeader,EventDialogContentRoot,EventDialogForm,EventDialogFormActions) are internal again.dependencyArrowsstyle override.Not included
Two dependency slots get no class on purpose:
DependencyDialogAnchor: a 0×0 span that only positions the dialog.DependencyInteractions: the invisible hit areas of the arrows. If customizing the delete button is wanted, a dedicated class can come later.Adding a class later is not breaking, removing one is.
Note
The classes are public surface: they show up in the API reference before the props. Land this right before the public flip, or in the same release.