Update on wapi.js, GetChat Throwing error#785
Open
daniel-scatigno wants to merge 1 commit intomukulhase:masterfrom
Open
Update on wapi.js, GetChat Throwing error#785daniel-scatigno wants to merge 1 commit intomukulhase:masterfrom
daniel-scatigno wants to merge 1 commit intomukulhase:masterfrom
Conversation
the function window.WAPI.getChat was throwing error when no chat was found, but it was supposed to return undefined I just added an "if (found)" before adding the function sendMessage to object found If object "found" is undefined is impossible to set a function and this throw an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the function window.WAPI.getChat was throwing error when no chat was found, but it was supposed to return undefined
I just added an "if (found)"
before adding the function sendMessage to object found
If object "found" is undefined is impossible to set a function and this throw an error