Skip to content

fix(server): load PR uploads from orgs that enforce SAML SSO - #88

Closed
mwolson wants to merge 1 commit into
contrib/mobile-thread-context-idfrom
contrib/sso-pr-media
Closed

mwolson wants to merge 1 commit into
contrib/mobile-thread-context-idfrom
contrib/sso-pr-media

Conversation

@mwolson

@mwolson mwolson commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

What Changed

Carries pingdotgg#19191 sso-pr-media by cbangera2, adapted to the GitHub source-control driver's media fetch. When github.com answers a pull request upload with its SAML SSO sign-in page, the driver renders the upload through the markdown API, which accepts the SSO-authorized token and returns a signed private-user-images URL, then fetches that URL without the token. The media request now carries the checkout, so an upload whose URL names no repository is rendered with the checkout's own GitHub repository as context, including a project rooted at a bare clone. Signed URLs are cached for four of their five minutes so video seeks reuse them. Organizations without SSO make no extra requests.

Why

Images and videos in pull request descriptions from SSO-enforcing organizations show "Image unavailable" in the PR panel. Drop this layer at the refresh after pingdotgg#19191 sso-pr-media merges upstream.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

@mwolson
mwolson added this pull request to stack #90 October 17, 2026 14:25
@mwolson
mwolson removed this pull request from stack #90 October 17, 2026 17:28
@mwolson
mwolson added this pull request to stack #92 October 17, 2026 17:29
@mwolson
mwolson removed this pull request from stack #92 October 17, 2026 23:04
@mwolson
mwolson added this pull request to stack #96 October 17, 2026 23:05
@mwolson
mwolson force-pushed the contrib/mobile-thread-context-id branch from f48ec27 to da05a6d Compare October 22, 2026 03:11
@mwolson
mwolson force-pushed the contrib/sso-pr-media branch from 978f34e to b949423 Compare October 22, 2026 03:11
@mwolson
mwolson removed this pull request from stack #96 October 22, 2026 04:53
@mwolson
mwolson added this pull request to stack #99 October 22, 2026 04:54
@mwolson
mwolson force-pushed the contrib/sso-pr-media branch 2 times, most recently from e7e89c0 to ea8a3d1 Compare October 24, 2026 00:11
@mwolson
mwolson force-pushed the contrib/mobile-thread-context-id branch from 7686216 to ea436c2 Compare October 24, 2026 00:38
@mwolson
mwolson force-pushed the contrib/sso-pr-media branch from ea8a3d1 to 94edaf8 Compare October 24, 2026 00:38
@mwolson
mwolson removed this pull request from stack #99 October 24, 2026 01:36
@mwolson
mwolson added this pull request to stack #101 October 24, 2026 01:36
@mwolson
mwolson force-pushed the contrib/sso-pr-media branch from 94edaf8 to b4ad4fd Compare October 24, 2026 16:10
@mwolson
mwolson removed this pull request from stack #101 October 24, 2026 19:49
@mwolson
mwolson added this pull request to stack #103 October 24, 2026 19:50
Carries pingdotgg#19191 sso-pr-media by cbangera2, adapted to the
GitHub source-control driver's media fetch. When github.com answers an
upload fetch with its SSO sign-in page, the driver renders the upload
through the markdown API, which honours the SSO-authorized token and
returns a signed private-user-images URL, then fetches that URL without
the token. The media request now carries the checkout, so an upload
without a repository in its URL is rendered with the checkout's own
GitHub repository as context.
Drop this layer at the refresh after pingdotgg#19191 sso-pr-media merges upstream.
@mwolson
mwolson removed this pull request from stack #103 October 29, 2026 11:33
@mwolson
mwolson force-pushed the contrib/mobile-thread-context-id branch from 20e327e to d868d3f Compare October 29, 2026 11:33
@mwolson
mwolson force-pushed the contrib/sso-pr-media branch from b4ad4fd to ad7b077 Compare October 29, 2026 11:33
@mwolson
mwolson added this pull request to stack #104 October 29, 2026 11:34
@mwolson
mwolson removed this pull request from stack #104 October 30, 2026 00:23
@mwolson
mwolson added this pull request to stack #106 October 30, 2026 00:24
@mwolson
mwolson removed this pull request from stack #106 October 30, 2026 18:14
@mwolson
mwolson added this pull request to stack #108 October 30, 2026 18:15
@mwolson
mwolson removed this pull request from stack #108 November 6, 2026 18:54
@mwolson
mwolson added this pull request to stack #110 November 6, 2026 18:55
@mwolson
mwolson removed this pull request from stack #110 November 9, 2026 22:52
@mwolson
mwolson added this pull request to stack #112 November 9, 2026 22:52
@mwolson
mwolson removed this pull request from stack #112 November 10, 2026 03:11
@mwolson

mwolson commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

Dropped in the 2026-11-09 refresh: upstream pingdotgg#21632 (a09aef3) loads PR uploads from SSO organizations with the same design.

@mwolson mwolson closed this Nov 10, 2026
@mwolson
mwolson deleted the contrib/sso-pr-media branch November 10, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants