Always save CSV with UTF-8 encoding by mx-psi · Pull Request #67 · mx-psi/fa-scraper

mx-psi · 2022-01-04T11:23:26Z

Fixes #66 by:

Updating test output with new film whose director has a character that can't be encoded in Python's default encoding for Windows (CP-1252)
Setting encoding to UTF-8 explicitly when opening the csv
Updating csv-diff to use fix comparing of csv files with non-default file encoding simonw/csv-diff#19 so that we can set the encoding explicitly when comparing on Windows

Update test output to include director with 'ō' in name

5b3dd75

mx-psi mentioned this pull request Jan 4, 2022

Error al crear el fichero csv #66

Closed

mx-psi added 2 commits January 4, 2022 12:36

Set encoding to UTF-8 explicitly

2494f9d

Use csv-diff fork to specify encoding

d7c91ae

mx-psi marked this pull request as ready for review January 4, 2022 13:08

mx-psi enabled auto-merge (squash) January 4, 2022 13:09

mx-psi changed the title ~~Update test output~~ Always save CSV with UTF-8 encoding Jan 4, 2022

Merge branch 'main' into mx-psi/new-tests

27a4489

mx-psi merged commit 10fd071 into main Jan 4, 2022

mx-psi deleted the mx-psi/new-tests branch January 4, 2022 13:15

Provide feedback