Dispatcher implementations #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxcl
reviewed
Feb 28, 2019
| @@ -0,0 +1,31 @@ | |||
| #if !os(Linux) | |||
Owner
There was a problem hiding this comment.
We can instead add this to the exclude list in Package.swift for this target.
mxcl
reviewed
Feb 28, 2019
| /// A PromiseKit Dispatcher that allows no more than X simultaneous | ||
| /// executions at once. | ||
|
|
||
| class ConcurrencyLimitedDispatcher: Dispatcher { |
Owner
There was a problem hiding this comment.
Nice, we can remove the when() that does this manually. I figure. Haven't analyzed them both.
Owner
|
This is really great, and truly shows the value of your changes, my sincere thanks and respect! |
mxcl
added a commit
that referenced
this pull request
Feb 28, 2019
* Add StrictRateLimitedDispatcher * Add ConcurrencyLimitedDispatcher * StrictRateLimitedDispatcher now schedules only on execution * Refactor rate limited dispatchers onto common base * Limiter dispatchers complete and tested * Add CoreDataDispatcher * Grooming, doc comments, NSLock -> DispatchQueue * Break Dispatcher implementation tests into separate classes to allow parallelism * Move time measurement outside of serialization for rate limit test * Update testing for Linux and slow Travis environments * Build all v7 branches
mxcl
added a commit
that referenced
this pull request
Feb 28, 2019
* Add StrictRateLimitedDispatcher * Add ConcurrencyLimitedDispatcher * StrictRateLimitedDispatcher now schedules only on execution * Refactor rate limited dispatchers onto common base * Limiter dispatchers complete and tested * Add CoreDataDispatcher * Grooming, doc comments, NSLock -> DispatchQueue * Break Dispatcher implementation tests into separate classes to allow parallelism * Move time measurement outside of serialization for rate limit test * Update testing for Linux and slow Travis environments * Build all v7 branches
mxcl
added a commit
that referenced
this pull request
Mar 1, 2019
* Add StrictRateLimitedDispatcher * Add ConcurrencyLimitedDispatcher * StrictRateLimitedDispatcher now schedules only on execution * Refactor rate limited dispatchers onto common base * Limiter dispatchers complete and tested * Add CoreDataDispatcher * Grooming, doc comments, NSLock -> DispatchQueue * Break Dispatcher implementation tests into separate classes to allow parallelism * Move time measurement outside of serialization for rate limit test * Update testing for Linux and slow Travis environments * Build all v7 branches
mxcl
added a commit
that referenced
this pull request
Mar 26, 2019
* Add StrictRateLimitedDispatcher * Add ConcurrencyLimitedDispatcher * StrictRateLimitedDispatcher now schedules only on execution * Refactor rate limited dispatchers onto common base * Limiter dispatchers complete and tested * Add CoreDataDispatcher * Grooming, doc comments, NSLock -> DispatchQueue * Break Dispatcher implementation tests into separate classes to allow parallelism * Move time measurement outside of serialization for rate limit test * Update testing for Linux and slow Travis environments * Build all v7 branches
mxcl
added a commit
that referenced
this pull request
Apr 8, 2019
* Add StrictRateLimitedDispatcher * Add ConcurrencyLimitedDispatcher * StrictRateLimitedDispatcher now schedules only on execution * Refactor rate limited dispatchers onto common base * Limiter dispatchers complete and tested * Add CoreDataDispatcher * Grooming, doc comments, NSLock -> DispatchQueue * Break Dispatcher implementation tests into separate classes to allow parallelism * Move time measurement outside of serialization for rate limit test * Update testing for Linux and slow Travis environments * Build all v7 branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not for direct integration yet, just review.
I groomed the
Dispatcherobjects I ended up writing for another project and put them into a release-ready state. Take a look and see if you'd be interested in having these somewhere in the PromiseKit universe.They're simple but probably too peripheral to put in the core; however, they might make a reasonable add-on package. I suspect that these few applications would cover 90% of the things people might be interested in using
Dispatcherobjects for in the real world.Contents:
RateLimitedDispatcherimplements general dispatch rate limits with a token bucket (approximate) strategy.StrictRateLimitedDispatcheris an exact and optimal sliding window rate limiter, but requires O(n) space (n = # of events/interval)ConcurrencyLimitedDispatcherallows only n asynchronous closures to run at once.CoreDataDispatcherlets you dispatch onto threads associated withNSManagedObjectContexts.CoreDataDispatcheris trivial.ConcurrencyLimitedDispatcheris just a few lines of code as well, although the exact way to implement it might not be obvious to those without some GCD knowledge.The other two are a bit tricky to implement correctly and efficiently, so that's where I would locate the main value of releasing this stuff.