Async/await #1291
Merged
Async/await #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxcl
approved these changes
Jul 24, 2022
mxcl
requested changes
Jul 24, 2022
Owner
mxcl
left a comment
mxcl
left a comment
There was a problem hiding this comment.
Needs to pass CI, our strategy with these typically is to add the #if inside the test bodies so that they pass because they have no content.
Collaborator
Author
Fixed. |
mxcl
approved these changes
Jul 25, 2022
mxcl
approved these changes
Jul 25, 2022
Owner
|
v6.18.0 released. Thanks for the contribution. |
Owner
|
This broke probably an awful lot of people I will revert these changes if we cannot analyze the issue and fix it (with CI checks) within 24 hours. Refs #1292 |
Owner
|
K possibly this is just we now require a newer Xcode https://stackoverflow.com/questions/69284960/ios-concurrency-is-only-available-in-ios-15-0-0-or-newer-in-protocol |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for PromiseKit.
Added compatibility with async/await.