Fix DefaultVFS listing .class files as resources#3691
Open
EvanYao826 wants to merge 1 commit into
Open
Conversation
DefaultVFS.list() recursively processes .class files as resources, which causes IllegalArgumentException in Tomcat 9.0.118+ / 10.1.55+ due to improved resource path validation (StandardRoot.validate normalizes resource paths containing .class file content to null). Added an early-return check at the beginning of the list() method to skip .class files since they cannot contain child resources. Fixes mybatis#3689
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3689
Problem
DefaultVFS.list()recursively processes.classfiles as resources, which causesIllegalArgumentExceptionin Tomcat 9.0.118+ / 10.1.55+ due to improved resource path validation inStandardRoot.validate.Fix
Added an early-return check at the beginning of
DefaultVFS.list()to skip.classfiles, since they are not directories and cannot contain child resources.Test
Added a unit test
listShouldSkipClassFilesthat verifies.classfile URLs return an empty list.