Improves the Keybinding parsing logic #1421
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an extra parsing to the Keybindings script, making some of the keys more readable and allowing "mod only" shortcuts to be properly represented/
Changes
Context
I use SUPER alone as the Keybind to open the app launcher in my local system.
To achieve that, you need to declare it like this:
bindr = $mainMod, $mainMod_L, exec, $HYPRSCRIPTS/launcher.sh # Open application launcher
This breaks the original keybindings window script as it can't parse "bindr" and even if it could, it would result in SUPER + SUPER_L as the "key"
The improved version handles those cases and also makes some of the keys more human readable (like common FN keys that are currently named XF86_*)
How Has This Been Tested?
Checklist
Please ensure your pull request meets the following requirements:
Screenshots
Related Issues
N/A
Additional Notes
hyprwm/Hyprland#2506