Draft
Conversation
Signed-off-by: Torstein Grindvik <torstein.grindvik@muybridge.com>
Draft
Owner
|
Thank you for experimenting with this. Fiber-based visualization is definitely desirable for Rust, especially async and tracing integration. Unfortunately the profiling perf impact simply by enabling fiber feature is so severe that I never really pursued it further. It definitely is not something that we could enable by default, and that alone requires a lot of design work, unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not pretty (the Rust code I mean)- I just wanted to see what it looked like.
EDIT: I whoopsed the location of the join prints, nvm them
One strange thing is that it reports finishing after negative time:
The example follows section "3.10 Fiber" of the Tracy manual. Kinda. Added some subspans just to see things nest well.
All in all I think this is interesting- doing this properly could allow having Rust work sent across threads properly tracked. Not sure how it looks in a real life complex app with lots and lots of spans though.
Opening up in case someone wants to try/discuss. I don't intend to do anything more at the moment.