feat(frontend): migrate toolchain to vite-plus#386
Draft
nakatanakatana wants to merge 4 commits intomainfrom
Draft
feat(frontend): migrate toolchain to vite-plus#386nakatanakatana wants to merge 4 commits intomainfrom
nakatanakatana wants to merge 4 commits intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the repo’s frontend tooling from separate Vite/Vitest/Biome setup to the unified Vite+ toolchain driven by the vp CLI, consolidating configuration and updating test imports accordingly.
Changes:
- Replaces legacy config (
vite.config.js,biome.json) with a consolidatedvite.config.ts(build/test/lint/fmt/staged). - Updates
package.jsonscripts/deps and TypeScript types to use Vite+ (vp) andvite-plus/test. - Adds an OpenSpec capability doc and a Vite+ pre-commit hook.
Reviewed changes
Copilot reviewed 172 out of 175 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.js | Removed legacy Vite/Vitest config in favor of unified Vite+ config. |
| vite.config.ts | New unified Vite+ config (Vite plugins, Vitest projects, lint/fmt/staged). |
| biome.json | Removed Biome configuration (migrated under Vite+ workflow). |
| package.json | Switches scripts to vp and updates deps/overrides for Vite+ core/test packages. |
| tsconfig.json | Updates global test types to vite-plus/test/globals and includes vite.config.ts. |
| panda.config.ts | Formatting-only change to keep config consistent with new formatter. |
| .vite-hooks/pre-commit | Adds Vite+ hook entrypoint (vp staged). |
| openspec/specs/frontend-unified-tooling/spec.md | Adds OpenSpec capability describing the unified frontend tooling. |
| frontend/src/vitest-setup.ts | Switches setup imports from vitest to vite-plus/test. |
| frontend/src/vite-plus-test-env.d.ts | Adds Vite+ test environment type imports. |
| frontend/src/** | Broad mechanical updates: replace vitest / vitest/browser imports with vite-plus/test / vite-plus/test/browser and apply formatting normalization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+1
to
+5
| ## ADDED Requirements | ||
|
|
||
| ### Requirement: Unified Frontend CLI | ||
|
|
||
| The system SHALL provide a single CLI (`vp`) to handle all frontend development, build, testing, and validation tasks. |
Comment on lines
+77
to
+86
| plugins: [ | ||
| devtools() as any, | ||
| tanstackRouter({ | ||
| target: "solid", | ||
| routesDirectory: path.join(workspaceRoot, "frontend/src/routes"), | ||
| generatedRouteTree: path.join(workspaceRoot, "frontend/src/routeTree.gen.ts"), | ||
| autoCodeSplitting: true, | ||
| }), | ||
| solid(), | ||
| process.env.ANALYZE === "true" && [ |
Comment on lines
+209
to
+214
| staged: { | ||
| "*.{js,jsx,ts,tsx}": "vp check --fix", | ||
| }, | ||
| } as any; | ||
|
|
||
| export default defineConfig(config); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (7242a8a) | #386 (68ae1cc) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 55.1% | 54.9% | -0.2% |
| Files | 137 | 137 | 0 |
| Lines | 9706 | 9648 | -58 |
- | Covered | 5351 | 5300 | -51 |
- | Code to Test Ratio | 1:1.3 | 1:1.2 | -0.1 |
| Code | 12664 | 12534 | -130 |
- | Test | 16754 | 15742 | -1012 |
- | Test Execution Time | 1m52s | 2m19s | +27s |Code coverage of files in pull request scope (88.9% → 89.1%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrated the frontend toolchain from standalone Vite, Vitest, and Biome to the unified Vite+ toolchain. This change consolidates development, build, testing, and validation into a single, cohesive workflow powered by the
vpCLI.Key Changes
vite.config.js, Biome settings, and Vitest configurations into a single, type-safevite.config.ts.package.jsonscripts to usevp dev,vp build,vp test, andvp check.vitestimports withvite-plus/testacross all test files.@biomejs/biome,vite,vitest, and other redundant devDependencies.vite-plusas the primary development dependency.frontend-unified-toolingcapability inopenspec/specs/.openspec/changes/archive/2026-03-18-migrate-to-vite-plus/.Verification Results
vp checkpasses (linting, formatting, and type-checking).vp testpasses for both Node.js and Browser-based tests.vp buildsuccessfully generates optimized production assets.vp devstarts the server with functional HMR.