Removed named define of AMD module and returning factory on the root#184
Open
wallynm wants to merge 1 commit intonakupanda:masterfrom
wallynm:master
Open
Removed named define of AMD module and returning factory on the root#184wallynm wants to merge 1 commit intonakupanda:masterfrom wallynm:master
wallynm wants to merge 1 commit intonakupanda:masterfrom
wallynm:master
Conversation
Owner
|
Let's bring someones here to review |
Contributor
|
Hey @wallynm ! Will that work when you have multiple files merged into one file. Will requirejs know that the lib is registered in the runtime context? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD require was been configured with a named package, blocking the definition of new names or other configurations, also it wasn't returning the factory into the Root making need of configure it locally on the app. With these little change you don't need any additional config.