Add code to distinguish cmd and electron envirmonment#200
Merged
nakupanda merged 3 commits intonakupanda:masterfrom Nov 10, 2015
codepiano:master
Merged
Add code to distinguish cmd and electron envirmonment#200nakupanda merged 3 commits intonakupanda:masterfrom codepiano:master
nakupanda merged 3 commits intonakupanda:masterfrom
codepiano:master
Conversation
The way to judge whether in CommonJs style can not distinguish real CommonJs from electron, will case BootstrapDialog object set to window.module.exports. Same problem may occur in node webkit,but I do not test this situation.
Owner
|
@jbolila @AndrewEastwood @bitclaw Hi guys, can you please review this pull request and comment on it when have time... |
Contributor
|
@codepiano, @nakupanda the latest changes look good for me. |
nakupanda
added a commit
that referenced
this pull request
Nov 10, 2015
Add code to distinguish cmd and electron envirmonment
Owner
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way to judge whether in CommonJs style can not distinguish real
CommonJs from electron, will cause BootstrapDialog object set to
window.module.exports
Same problem may occur in node webkit,but I do not test this situation.
And actually,This is a monkey patch from a java programmer.... so maybe there's a better way to fix this.
😊