Added a new feature that is scrolling modal body When content is over window.#216
Open
carldai0106 wants to merge 11 commits intonakupanda:masterfrom
Open
Added a new feature that is scrolling modal body When content is over window.#216carldai0106 wants to merge 11 commits intonakupanda:masterfrom
carldai0106 wants to merge 11 commits intonakupanda:masterfrom
Conversation
Owner
|
Sorry, I think this is another pull request I have missed. The idea is great, it's worth adding as a new feature, but I think we need to improve it before merging it into main branch. |
Owner
|
Reopening to receive more feedback. |
Author
|
I am not good at javascript, If I have more time (Chinese new year is coming, I have fifteen days of the Spring Festival holiday ) I will optimize it. So I want to close it. Maybe @nakupanda you can help me to refactor it ( getResizeOptions method). |
Owner
|
Spend more time with your family, holiday is not for tough working. Gong Xi Fa Cai 恭喜发财! |
Author
|
@nakupanda Thank you!!!! |
added 4 commits
February 22, 2016 16:38
get all updates from author
Author
|
@nakupanda |
carldai0106
changed the title
carldai0106
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.