Skip to content

Remove the concept of DefaultRecordsSelection from ensnode-sdk #1084

@lightwalker-eth

Description

@lightwalker-eth

Background

It is assumed that the goal that motivated the creation of DefaultRecordsSelection was to optimize the DX for record resolution. That's a good goal and coming from a good place. However, in ENS there is no such thing as a "default record selection" when performing record resolution / forward resolution. The current framing of this idea as a "default" will create misunderstandings.

Each app must explicitly define for itself what records are relevant for it and explicitly request those records.

The only (optional) exception to this is described in #1083

Each app should build their own tailored data models around record resolution requests similar to the ideas described in #1082

The broader goal of optimizing the DX of our record resolution APIs is a great one but is outside the scope of this issue and should not be achieved through DefaultRecordsSelection. An issue to track this opportunity has already been created at #976 and https://github.com/namehash/ensnode/issues/897.

Goals

  • Remove the concept of DefaultRecordsSelection from ensnode-sdk
  • Update the protocol inspector in ENSAdmin to manage its definition of the records to explicitly request resolution of.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions