You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ensnode/datasources then depends on enssdk to get the EnsNamespaceId
as part of this, perhaps migrate some of the namespace utils to enssdk as well
make sure to consider the module size impact of including the datasources/abis necessary to implement those helpers
NormalizedAddress branded type refactor, asLowerCaseAddress becomes asNormalizedAddress etc
definitely need something like asInterpretedName to go from Name to InterpretedName with a helpful api for consumers like the example app parsing url params
current it just validates, but we should allow converstion
refactor the packages/enssdk/src/lib/names.ts utils to accept InterpretedName instead of Name or NormalizedName
likely allows us to get rid of NormalizedName entirely — make sure that the protocol acceleration lib can use InterpretedName instead of NormalizedName
update the test case in apps/ensapi/src/lib/handlers/params.schema.test.ts to test interpreted names as well as normalized names
clean up apps/ensrainbow/src/commands/convert-csv-command.test.ts to use the await expect().resolves pattern
reference: #1867 (comment)
enssdk@ensnode/datasourcesthen depends onenssdkto get the EnsNamespaceIdNormalizedAddressbranded type refactor,asLowerCaseAddressbecomesasNormalizedAddressetcasInterpretedNameto go from Name to InterpretedName with a helpful api for consumers like the example app parsing url paramspackages/enssdk/src/lib/names.tsutils to accept InterpretedName instead of Name orNormalizedNameNormalizedNameentirely — make sure that the protocol acceleration lib can useInterpretedNameinstead ofNormalizedNameapps/ensapi/src/lib/handlers/params.schema.test.tsto test interpreted names as well as normalized namesapps/ensrainbow/src/commands/convert-csv-command.test.tsto use theawait expect().resolvespattern