-
Notifications
You must be signed in to change notification settings - Fork 16
use namespace id and avatar url hooks #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f503380
use namespace id and avatar url hooks
notrab 630a6f9
formatting
notrab 5342311
Update apps/ensadmin/src/hooks/useAvatarUrl.ts
notrab 4f135b6
Update apps/ensadmin/src/hooks/useNamespaceId.ts
notrab 4228c30
Update apps/ensadmin/src/hooks/useNamespaceId.ts
notrab b5105a7
Update apps/ensadmin/src/hooks/useNamespaceId.ts
notrab 4ef3b92
rename network to namespace
notrab eb13280
update jsdoc for avatar hook
notrab 92e6a41
remove isLoading state
notrab 25f8726
avatar url
notrab 299a5b5
simplify hooks
notrab 67abb36
fix ens app link
notrab 114f7fd
Apply fixes (#1076)
lightwalker-eth ffe633a
Fix docs for useNamespaceId
lightwalker-eth ca4f9fc
Implement unexecuted suggestion
lightwalker-eth d59b382
Fix JSDoc for useAvatarUrl
lightwalker-eth 94b8db9
improve clarity of ideas
lightwalker-eth 2761e48
Improve JSDoc
lightwalker-eth 79ccf65
refactor and fix namespace access and ens app url
shrugs 26723f3
Merge branch 'main' into use-namespace-id
shrugs 175abaf
fix: lint
shrugs 37422df
Merge branch 'main' into use-namespace-id
shrugs 8b3db1f
fix: only access namespace in ensadmin-specific components with useAc…
shrugs 6a034c5
refactor: naming pattern, re-org hooks folder for clarity
shrugs 59f0a0c
docstrings
shrugs 3854ec7
docstrings
shrugs 9e187d4
naming
shrugs ce29679
tweak jsdoc
notrab ea956a0
Merge branch 'main' into use-namespace-id
notrab bdfbcd4
docs(changeset): New hooks useNamespace, useEnsMetadataServiceAvatarU…
notrab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "ensadmin": minor | ||
| --- | ||
|
|
||
| New hooks useNamespace, useEnsMetadataServiceAvatarUrl, and useENSAppProfileUrl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
apps/ensadmin/src/app/name/[name]/NameDetailPageSkeleton.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| "use client"; | ||
|
|
||
| import { Card, CardContent, CardHeader } from "@/components/ui/card"; | ||
| import { Skeleton } from "@/components/ui/skeleton"; | ||
|
|
||
| export function NameDetailPageSkeleton() { | ||
| return ( | ||
| <div className="container mx-auto p-6 max-w-4xl"> | ||
| <div className="mb-8"> | ||
| <div className="flex items-center gap-4 mb-4"> | ||
| <Skeleton className="h-20 w-20 rounded-full" /> | ||
| <div className="space-y-2"> | ||
| <Skeleton className="h-8 w-48" /> | ||
| <div className="flex items-center gap-2"> | ||
| <Skeleton className="h-6 w-20" /> | ||
| <Skeleton className="h-8 w-32" /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div className="space-y-6"> | ||
| <Card> | ||
| <CardHeader> | ||
| <Skeleton className="h-6 w-32" /> | ||
| </CardHeader> | ||
| <CardContent className="space-y-4"> | ||
| <div> | ||
| <Skeleton className="h-4 w-20 mb-1" /> | ||
| <Skeleton className="h-4 w-full" /> | ||
| </div> | ||
| <div className="flex items-center gap-2"> | ||
| <Skeleton className="h-4 w-4" /> | ||
| <Skeleton className="h-4 w-32" /> | ||
| </div> | ||
| </CardContent> | ||
| </Card> | ||
|
|
||
| <Card> | ||
| <CardHeader> | ||
| <Skeleton className="h-6 w-24" /> | ||
| </CardHeader> | ||
| <CardContent className="space-y-3"> | ||
| <div className="flex items-center gap-2"> | ||
| <Skeleton className="h-4 w-4" /> | ||
| <Skeleton className="h-4 w-24" /> | ||
| </div> | ||
| </CardContent> | ||
| </Card> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
apps/ensadmin/src/components/providers/active-ensnode-provider.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| "use client"; | ||
|
|
||
| import { useActiveENSNodeUrl } from "@/hooks/active/use-active-ensnode-url"; | ||
| import { ENSNodeProvider as _ENSNodeProvider } from "@ensnode/ensnode-react"; | ||
| import { PropsWithChildren } from "react"; | ||
|
|
||
| /** | ||
| * Provider component that configures ENSNodeProvider with the currently active ENSNode connection URL. | ||
| * | ||
| * This component wraps the ENSNodeProvider from @ensnode/ensnode-react and automatically | ||
| * configures it with the URL from the currently active ENSNode connection. It serves as | ||
| * a bridge between the connection management system and the ENSNode React hooks. | ||
| * | ||
| * @param children - React children to render within the provider context | ||
| */ | ||
| export function ActiveENSNodeProvider({ children }: PropsWithChildren) { | ||
| const url = useActiveENSNodeUrl(); | ||
|
|
||
| return <_ENSNodeProvider config={{ client: { url } }}>{children}</_ENSNodeProvider>; | ||
| } |
10 changes: 0 additions & 10 deletions
10
apps/ensadmin/src/components/providers/ensnode-provider.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.