Conversation
🦋 Changeset detectedLatest commit: b7e971e The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab Hey here's some feedback
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
|
@lightwalker-eth moving this out of draft since previous suggestions were implemented. One thing to note, is that I made some changes to the It automatically prepends |
| } | ||
|
|
||
| /** | ||
| * Builds a browser-supported asset URL for a name's asset image from the name's raw asset text record value. |
There was a problem hiding this comment.
| * Builds a browser-supported asset URL for a name's asset image from the name's raw asset text record value. | |
| * Builds a browser‑supported avatar image URL from the ENS avatar text record (key: "avatar"). | |
| * Accepts non‑browser protocols (ipfs://, ar://) and NFT URIs (CAIP‑22 ERC‑721 / CAIP‑29 ERC‑1155, eip155 chain namespace), | |
| * and converts them via a proxy/gateway (default: ENS Metadata Service) to http/https/data URLs. |
This keeps the "asset" generic type for reuse, but adjusts the JSDoc to emphasize the use of the "avatar text record" in this context.
|
I've just seen the changes made for ENSApi include the change of the |
Closes #1085
New Notes (from lightwalker)