Conversation
Drops from type and updates all consumers of type to know when they can access the property. Also, this PR drops type from ENSAdmin, as we can now rely on the one.
🦋 Changeset detectedLatest commit: f33c1d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ype from ENSNode SDK package.
lightwalker-eth
approved these changes
Oct 15, 2025
Member
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@tk-o Looks nice. Just 1 small comment. Please merge when ready 👍
|
|
||
| return chainEntries.map(([chainId, chain]) => { | ||
| const endBlock = chain.config.endBlock ? blockViewModel(chain.config.endBlock) : null; | ||
| const endBlock = chain.config.endBlock ? chain.config.endBlock : null; |
Member
There was a problem hiding this comment.
Suggest to update this logic to check chain.config.configType and then decide the endBlock based on that.
Contributor
Author
There was a problem hiding this comment.
Nice catch, will update.
Merged
notrab
pushed a commit
that referenced
this pull request
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops from type and updates all consumers of type to know when they can access the property. Also, this PR drops type from ENSAdmin, as we can now rely on the one.