Skip to content

feat(ensnode-sdk): shared module AccountId#1253

Merged
tk-o merged 3 commits intomainfrom
feat/1228-account-id-sdk
Nov 5, 2025
Merged

feat(ensnode-sdk): shared module AccountId#1253
tk-o merged 3 commits intomainfrom
feat/1228-account-id-sdk

Conversation

@tk-o
Copy link
Copy Markdown
Contributor

@tk-o tk-o commented Nov 5, 2025

Extends helpers avaialble for working with AccountId values. New helpers were included in ENSNode SDK in order to support goals related to the new registrars plugin.

Related to #1228.

@tk-o tk-o requested a review from a team as a code owner November 5, 2025 15:50
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 5, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 068739c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@ensnode/ensnode-sdk Minor
ensadmin Minor
ensapi Minor
ensindexer Minor
ensrainbow Minor
@ensnode/ensnode-react Minor
@ensnode/ensrainbow-sdk Minor
@ensnode/datasources Minor
@ensnode/ponder-metadata Minor
@ensnode/ensnode-schema Minor
@ensnode/ponder-subgraph Minor
@ensnode/shared-configs Minor
@docs/ensnode Minor
@docs/ensrainbow Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Nov 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
admin.ensnode.io Ready Ready Preview Comment Nov 5, 2025 5:05pm
ensnode.io Ready Ready Preview Comment Nov 5, 2025 5:05pm
ensrainbow.io Ready Ready Preview Comment Nov 5, 2025 5:05pm

@tk-o
feat(ensnode-sdk): shared module AccountId
b7e62c8 
Extends helpers avaialble for working with `AccountId` values. New helpers were included in ENSNode SDK in order to support goals related to the new `registrars` plugin.

Related to #1228.
@tk-o tk-o force-pushed the feat/1228-account-id-sdk branch from 2466a70 to b7e62c8 Compare November 5, 2025 15:52
lightwalker-eth
lightwalker-eth approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk-o Hey looks great. Shared a few small suggestions. Please merge when ready 👍

packages/ensnode-sdk/src/shared/zod-schemas.ts

return {
chainId: result.chainId.reference,
address: result.address,
Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to convert result.address to lowercase?

Copy link
Copy Markdown
Contributor Author

@tk-o tk-o Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The address will be converted to lowercase by makeSerializedAccountIdSchema which internally uses makeLowercaseAddressSchema when parsing the address value. The lowercase address format is assumed by our business logic, so this conversion is required.

@tk-o tk-o force-pushed the feat/1228-account-id-sdk branch from 283b515 to 068739c Compare November 5, 2025 17:04
@tk-o tk-o merged commit 40658a7 into main Nov 5, 2025
10 checks passed
@tk-o tk-o deleted the feat/1228-account-id-sdk branch November 5, 2025 17:07
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lightwalker-eth lightwalker-eth lightwalker-eth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tk-o @lightwalker-eth