feat(ensapi): Registrar Actions with referrals#1302
Merged
Conversation
Includes `withReferral` query param in the Registrar Actions API route which allows to filter out all "logical registrar actions" records that have `encodedReferrer` set to `null` or `zeroEncodedReferrer`.
🦋 Changeset detectedLatest commit: f5778fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lightwalker-eth
approved these changes
Nov 24, 2025
Member
lightwalker-eth
left a comment
There was a problem hiding this comment.
@tk-o Looks great! Nice work. Shared very small feedback. Please take the lead to merge and deploy a new RC (just of ENSApi maybe?) 👍
| EqualsTo: "eq", | ||
| export const RegistrarActionsFilterTypes = { | ||
| BySubregistryNode: "bySubregistryNode", | ||
| WithReferralIncluded: "withReferralIncluded", |
Member
There was a problem hiding this comment.
Suggested change
| WithReferralIncluded: "withReferralIncluded", | |
| WithEncodedReferral: "withEncodedReferral", |
| value: Node; | ||
| }; | ||
|
|
||
| export type RegistrarActionsFilterWithReferralIncluded = { |
Member
There was a problem hiding this comment.
Suggested change
| export type RegistrarActionsFilterWithReferralIncluded = { | |
| export type RegistrarActionsFilterWithEncodedReferral = { |
Rename types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes
withReferralquery param in the Registrar Actions API route which allows to filter out all "logical registrar actions" records that haveencodedReferrerset tonullorzeroEncodedReferrer.Suggested review order:
packages/ensnode-sdk/src/api/types.ts: addedfilterTypefield to distinguish among available filters and their params,packages/ensnode-sdk/src/api/registrar-actions/filters.ts: defined helpers allowing to create a filter object for any available filter,apps/ensapi/src/handlers/registrar-actions-api.ts: defined array of filters with conditional logic adding filters to the request object,apps/ensapi/src/lib/registrar-actions/find-registrar-actions.ts: updatedbuildWhereClausefunction to be able to build Drizzle SQL objects describing selectedfilters,packages/ensnode-sdk/src/client.ts: updatedregistrarActionsmethod so it can map the selectedfiltersinto Registrar Actions request object.Example use case: