Skip to content

Address current dependency issues #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tk-o merged 1 commit into from
Mar 12, 2026
Merged

Address current dependency issues #1755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@
"lodash@>=4.0.0 <=4.17.22": ">=4.17.23",
"lodash-es@>=4.0.0 <=4.17.22": ">=4.17.23",
"markdown-it@>=14.0.0 <14.1.1": ">=14.1.1",
"tar@<=7.5.9": "^7.5.10",
"tar@<=7.5.10": "^7.5.11",
"ajv@<8.18.0": ">=8.18.0",
"minimatch@<10.2.3": ">=10.2.3",
"rollup@>=4.0.0 <4.59.0": ">=4.59.0",
"svgo@>=3.0.0 <3.3.3": "^3.3.3",
"@hono/node-server@<1.19.10": "^1.19.10"
"ponder>@hono/node-server@<1.19.10": "^1.19.10"
Comment thread
tk-o marked this conversation as resolved.
},
"ignoredBuiltDependencies": [
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Override scope narrowed — may leave other consumers unprotected

The previous override key "@hono/node-server@<1.19.10" applied globally across the entire dependency tree. The new key "ponder>@hono/node-server@<1.19.10" only overrides the vulnerable version when @hono/node-server is a direct dependency of ponder.

If any other package in the monorepo (or any future package added to the workspace) transitively pulls in @hono/node-server@<1.19.10, it will no longer be caught by this override.

Since the stated goal of this PR is to address security issues, the broader global override was strictly safer. If the intention is to scope this specifically to ponder (because only ponder's transitive resolution needed fixing), that should be documented. Otherwise, consider reverting to the global form:

Suggested change
"ignoredBuiltDependencies": [
"@hono/node-server@<1.19.10": "^1.19.10"

Copy link
Copy Markdown
Contributor Author

@tk-o tk-o Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need global overrides but explicit ones. That is the intent.

"bun"
Expand Down
82 changes: 41 additions & 41 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ catalog:
caip: 1.1.1
date-fns: 4.1.0
drizzle-orm: 0.41.0
hono: ^4.12.4
hono: ^4.12.7
lucide-react: ^0.548.0
pg-connection-string: ^2.9.1
pino: 10.1.0
Expand Down
Loading