-
Notifications
You must be signed in to change notification settings - Fork 16
Use Ponder runtime logger across ENSIndexer app #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d1e9268
Add `logger: PonderAppLogger` field to `PonderAppContext` data model
tk-o e26bdb8
docs(changeset): Added `logger` field to `PonderAppContext` data model.
tk-o ad9ad55
Intergrated `logger` from Ponder SDK into ENSIndexer
tk-o b00f1ab
Updated ENSIndexer code to use the `logger` module
tk-o 930d692
Update testing suite
tk-o 5849432
docs(changeset): Enhanced application logging approach to use a strea…
tk-o b8161e7
Apply AI PR feedback
tk-o d47e15c
Merge remote-tracking branch 'origin/main' into feat/ensindexer-logge…
tk-o 7886966
Merge remote-tracking branch 'origin/main' into feat/ensindexer-logge…
tk-o de77f11
Update `PonderAppContext[logger]` instance
tk-o 3e3f068
Create a separate file to share `localPonderContext` instance
tk-o 009b53f
Remove `formatLogParam` and `buildLogError` helpers
tk-o 6247292
Replaced `prettyPrintJson` with `stringifyConfig`
tk-o 90c8aec
Apply AI PR feedback
tk-o c6b7cf7
nit: tidy up based on bot notes
shrugs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "ensindexer": minor | ||
| --- | ||
|
|
||
| Enhanced application logging approach to use a streamlined logger implementation across ENSIndexer app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@ensnode/ponder-sdk": minor | ||
| --- | ||
|
|
||
| Added `logger` field to `PonderAppContext` data model. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { vi } from "vitest"; | ||
|
|
||
| // Set up the global PONDER_COMMON.logger before mocking to allow importOriginal to work | ||
| const mockLogger = { | ||
| trace: vi.fn(), | ||
| debug: vi.fn(), | ||
| info: vi.fn(), | ||
| warn: vi.fn(), | ||
| error: vi.fn(), | ||
vercel[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }; | ||
tk-o marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| (globalThis as any).PONDER_COMMON = { logger: mockLogger }; | ||
|
|
||
| /** | ||
| * Mock the logger module to avoid the globalThis.PONDER_COMMON check. | ||
tk-o marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| */ | ||
| vi.mock("@/lib/logger", async () => { | ||
| return { | ||
| logger: mockLogger, | ||
| }; | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.