Clean up unit tests for CoreLibrary and complete tests for Type.GetType#143
Merged
Conversation
Added new tests for Type.GetType(string) to test classes inside of classes Cleaned up tests using Assert.IsType so the 1st parm is a Type and the 2nd parm is an object Added a few #pragma statements to ignore certain known warning conditions Removed unneeded variables to clean up warning messages Renamed some variables for consistency Fix #758
Contributor
Author
|
Requires native code changes to mscorlib (nanoCLR). Unit tests will fail unit native code catches up. |
josesimoes
reviewed
Jun 3, 2021
josesimoes
left a comment
Member
There was a problem hiding this comment.
Awesome!! Well done. This nails it. 🥇 💯 👏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up unit tests to remove warnings, fix consistency, add test cases
Motivation and Context
How Has This Been Tested?
Running unit tests on win32 for CoreLibrary
Screenshots
Types of changes
Checklist: