Add TryParse#168
Merged
Merged
Conversation
- Implement method in the various classes. - Remove checks for null params in all Parse calls (this check is now carried in native). - Rework existing NativeToInt64 and NativeToDouble with param to set throwing exception and to return conversion success/failure. - Add Unit Tests and some rework on the existing ones where these were added. - Fix documentation and update formatting to follow code style. - Bump AssemblyNativeVersion 100.5.0.15. (temporarily disable float and double infinity tests)
Member
Author
|
Unit Tests will fail because of the mismatch in WIN32 nanoCLR. |
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wit the overall changes (new feature+rework) this increases the PE size roughly ~200 bytes which seems cheap for the added value.
(temporarily disable float and double infinity tests)
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: