Repository navigation
feat: auto-restart + diagnostic + UX 3-state (PR-2 of v1.3.39) - #11
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 32160370 | Triggered | Telegram Bot Token | 7877998 | docs/QA-1.3.39.md | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4915a12f2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const attempts = countAutoInLastHour() | ||
| if (attempts >= MAX_AUTO_RESTARTS_PER_HOUR) { |
There was a problem hiding this comment.
scheduleAutoRestart() always gates retries by countAutoInLastHour(), so after 5 auto attempts the next crash will immediately emit gave_up again even if the user clicked Retry/manual start. Because manual start only clears gaveUp and pending timers (not persisted auto-attempt history), recovery stays blocked for up to an hour, which breaks the intended “manual action clears the cap” behavior.
Useful? React with 👍 / 👎.
|
|
||
| const PII_PATTERNS: Array<[RegExp, string]> = [ | ||
| // Telegram bot tokens: bot1234567890:AAH... | ||
| [/(bot\d+:)[A-Za-z0-9_-]{30,}/g, '$1****MASKED****'], |
There was a problem hiding this comment.
The Telegram masking regex only matches tokens prefixed with bot (e.g. bot123:...), but real bot secrets are commonly logged as raw <digits>:<secret> (for example in env dumps). In that case the diagnostic copy path will include the unredacted token, creating a sensitive-secret leak when users paste reports externally.
Useful? React with 👍 / 👎.
| useEffect(() => { | ||
| const unsub = window.electronAPI.gateway.onStatusChanged((s) => { | ||
| const unsub = window.electronAPI.gateway.onStatusChanged(({ status: s }) => { | ||
| setStatus(s === 'running' ? 'running' : 'stopped') |
There was a problem hiding this comment.
The status handler collapses every non-running supervisor state to stopped, so when the supervisor emits starting or restarting the UI flips to stopped and re-enables stopped-state actions while boot is still in progress. This regresses the new 3-state UX by showing an incorrect state during startup/restart windows.
Useful? React with 👍 / 👎.
…(v1.3.39) PR-2 of two for the v1.3.39 stability release. Builds on the supervisor core from PR-1 (#10) and adds the user-visible behavior: gateway crashes now self-heal, the tray surfaces what's happening, and a single "Copy Diagnostic Info" button gives non-developer users a way to share the actual crash output in the Kakao group chat. What this changes: - Auto-restart with exponential backoff (0/2/5/15/60 s) and a 5-per-hour hard cap. Manual user actions clear the cap so users can recover from the gave_up state. Restart attempts are persisted to gateway-restart-history.json so the cap survives app restarts. - New diagnostic-collector aggregates Electron / OS / Node info, the last 200 stderr lines, recent stdout, restart history, port ownership, plus per-platform extras (launchctl print on macOS, wsl --version + ss output inside the distro on Windows). All output is PII-masked: Telegram bot tokens, sk-* / AIza* / sk-ant-* API keys are redacted before leaving the diagnostic surface. - New diagnostic:collect / diagnostic:copy IPC + electronAPI.diagnostic bridge. - Tray gains a 3-state label (running / restarting / failed), a "Copy Diagnostic Info" menu item, and notifications for died / gave_up events (5 min throttle, except gave_up which always fires). - DoneStep shows a yellow "Gateway 자동 재시작 중" banner during restart, and a red "Gateway 재시작 실패" banner with a copy button when the cap is hit. The DiagnosticModal opens automatically on gave_up and lets the user retry, copy to clipboard, or jump to the Kakao open chat. - ipc-handlers now drives the supervisor from onboard:run and config:switch-provider so the gateway is alive when DoneStep mounts (no more 30 s polling fallback) and switchProvider boots the daemon exactly once instead of twice. - i18n keys for ko/en/ja/zh. - Bump version to 1.3.39 + QA checklist (docs/QA-1.3.39.md). Verification: npm run typecheck and npm run lint both clean (only the pre-existing LobsterLogo prettier warning remains, untouched).
scripts/release.mjs runs npm version patch on its own. Pre-bumping in the PR would push the next release to 1.3.40 instead of 1.3.39.
…older shape GitGuardian flagged the literal string in S7 because it matched the Telegram bot token regex. Switch to placeholder syntax that conveys the same instruction without tripping secret scanners.
db52b9e to
53e3bcb
Compare
Summary
PR-2 of two for v1.3.39, building on #10. Where PR-1 stayed
behind the curtain (lifecycle, logging, plist migration), this PR is
what users actually see when the gateway dies.
Base branch: `feat/gateway-supervisor` (PR #10). Merge order: PR-1 first, then this.
Test plan
See `docs/QA-1.3.39.md` for the full 7-scenario manual checklist (force-kill, crash loop, post-onboard alive, single boot on switchProvider, quit cleanup, log rotation, PII masking).