fix types to use module augmentation instead of @ts-ignore#116
Open
andyjy wants to merge 1 commit intoneondatabase:mainfrom
Open
fix types to use module augmentation instead of @ts-ignore#116andyjy wants to merge 1 commit intoneondatabase:mainfrom
andyjy wants to merge 1 commit intoneondatabase:mainfrom
Conversation
Contributor
Author
|
@jawj would you like me to update this PR for the refactor that just landed? If not then it can be closed - was just a few extra minutes work while working on a previous issue. I'd suggest on balance it's probably worth the additional type safety but fair to consider it mostly a stylistic choice for y'all. |
Collaborator
|
Hi @andyjy. Yes, please do update in the light of the refactor, and thanks for doing this. It's a definite improvement! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pffigueiredo - this PR shows how to use module type augmentation to prevent the requirement for
@ts-ignorethroughout.Just a suggestion - perhaps not huge benefit given the need to add (+ maintain?!) more detailed type declarations for the pg internals.
But it can bring some benefits e.g. exposes the actual type of
types: CustomTypesConfigwhere it was previouslyany