feat: export getVersion helper from @netlify/build#6984
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbitNew Features
WalkthroughThis pull request introduces a new utility function Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…sion (#8049) 🎉 Thanks for submitting a pull request! 🎉 #### Summary Relies on netlify/build#6984 This adds `build_version`, `framework` and `framework_version` metadata to CLI deploys so there is parity with buildbot deploys. Part of https://linear.app/netlify/issue/FRB-2141/cli-deploys-dont-set-netlifybuild-version-metadata Part of https://linear.app/netlify/issue/FRB-1384/framework-metadata-not-passed-through-from-manual-cli-deploys --- For us to review and ship your PR efficiently, please perform the following steps: - [ ] Open a [bug/issue](https://github.com/netlify/cli/issues/new/choose) before writing your code 🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you\`re fixing a typo or something that\`s on fire 🔥 (e.g. incident related), you can skip this step. - [ ] Read the [contribution guidelines](../CONTRIBUTING.md) 📖. This ensures your code follows our style guide and passes our tests. - [ ] Update or add tests (if any source code was changed or added) 🧪 - [ ] Update or add documentation (if features were changed or added) 📝 - [ ] Make sure the status checks below are successful ✅ **A picture of a cute animal (not mandatory, but encouraged)**
🎉 Thanks for submitting a pull request! 🎉
Summary
Part of https://linear.app/netlify/issue/FRB-2141/cli-deploys-dont-set-netlifybuild-version-metadata
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)