fix: strip leading slash from Docker container names#423
Merged
Conversation
Docker API returns container names with a leading slash (e.g., "/my-container"). When used in job names, this caused web UI history requests to fail with 404 because URLs like "/api/jobs//container.job-name/history" have a double slash. Fixes #422
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where Docker container names with leading slashes caused malformed URLs in the web UI, resulting in 404 errors when accessing job history. The fix strips the leading slash from container names returned by the Docker API's ContainerList endpoint.
Key Changes
- Strip leading
/from container names inconvertFromAPIContainerfunction - Update tests to expect container names without leading slashes
- Add comprehensive regression test comments referencing issue #422
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
core/adapters/docker/convert.go |
Added strings import and modified convertFromAPIContainer to strip leading slash from container names using strings.TrimPrefix |
core/adapters/docker/convert_test.go |
Updated all test cases to expect container names without leading slashes and added clear regression test comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/from container names returned by Docker APIRoot Cause
Docker API returns container names with a leading slash (e.g.,
/my-container). When used in job names, this caused web UI history requests to fail:Fix
In
core/adapters/docker/convert.go, strip the leading slash when converting from Docker API container summary.Test plan
Fixes #422