fix(ci): work around SLSA builder private repo detection bug#428
Merged
fix(ci): work around SLSA builder private repo detection bug#428
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR works around a bug in the SLSA GitHub builder that incorrectly detects public repositories as private, causing release builds to fail. The fix sets private-repository: true in the SLSA workflow configuration, which paradoxically allows the build to proceed for this public repository.
Key Changes:
- Modified the
private-repositoryparameter fromfalsetotruein the SLSA builder workflow configuration
The SLSA builder incorrectly detects public repositories as private, causing builds to fail with 'Repository is private' error. Setting private-repository: true allows the build to proceed while still uploading provenance to the public transparency log (repo is public anyway). This is a known issue with slsa-github-generator: slsa-framework/slsa-github-generator#942
CybotTM
force-pushed
the
fix/slsa-private-repo-workaround
branch
from
dd5130a to
c017457
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
private-repository: trueallows the build to proceedRelated Issues
Test plan
Sources: