test: comprehensive test coverage improvement (60% → 82.5%)

[CybotTM]

Summary

• Increase overall statement coverage from ~60% to 82.5% (+22.5 percentage points)
• Add 7,561 lines of new test code across 31 test files covering all packages
• Fix linter issues (testifylint, goconst, gofumpt, gci, misspell, dupl, copyloopvar)
• Refactor duplicate enable/disable job handlers into shared toggleJobHandler
• Fix concurrency issues, CSRF race condition, auth panic, and other bugs found during testing

Coverage by Package

Package	Before	After
core/domain	~70%	100%
core/ports	~60%	100%
metrics	~50%	100%
test	~80%	100%
config	~90%	97.8%
core/adapters/mock	~90%	97.1%
test/testutil	~80%	96.2%
core	~65%	90.1%
middlewares	~55%	88.1%
web	~60%	84.0%
cli	~50%	78.9%

New Test Files (26 files)

Phase 1 - Domain & Ports:

• core/domain/{errors,event,exec,image,service}_test.go
• core/ports/docker_test.go, test/testlogger_test.go

Phase 2 - Core Jobs:

• core/{runjob,execjob,runservice}_unit_test.go
• core/{resilient_job,shutdown_unit,clock_unit}_test.go

Phase 3 - Middlewares:

• Extended: middlewares/{webhook,preset,dedup,sanitize,mail,overlap,save,slack}_test.go

Phase 4-6 - CLI, Web, Metrics:

• cli/{config_ext,config_validate_ext,daemon_ext,doctor_ext,progress_ext}_test.go
• web/{auth_secure_ext,server_ext}_test.go, metrics/prometheus_ext_test.go

Phase 7-8 - Docker Adapter & Partials:

• core/adapters/docker/{container_convert,service_convert}_test.go
• Extended: cli/config_decode_test.go, middlewares/{restore,preset_cache,webhook_config,webhook_security}_test.go

Test plan

• All tests pass: go test ./... -count=1 (14 packages OK)
• Linter clean: golangci-lint run ./... (0 issues)
• Coverage verified: 82.5% total statement coverage
• No race conditions: tests use t.Parallel() throughout

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[github-actions]

Automated approval for solo maintainer project

All CI checks passed. See SECURITY.md for compensating controls.

[github-actions]

✅ Mutation Testing Results

Mutation Score: 86.67% (threshold: 60%)

✨ Good job! Mutation score meets the threshold.

What is mutation testing?

Mutation testing measures test quality by introducing small changes (mutations) to the code and checking if tests detect them. A higher score means better test effectiveness.

• Killed mutants: Tests caught the mutation (good!)
• Survived mutants: Tests missed the mutation (needs improvement)

[Copilot]

Pull request overview

This PR substantially increases automated test coverage across the Ofelia codebase while also hardening several runtime paths (web server request handling, token/rate-limiter lifecycle, scheduler concurrency, and metrics gauge updates).

Changes:

• Add extensive new/extended unit tests across core, web, middlewares, cli, config, metrics, and adapter packages to raise total coverage to ~82.5%.
• Harden web server behavior: validate job names, enforce HTTP methods, improve status codes, prevent auth/status panic, and add shutdown cleanup for background goroutines.
• Improve concurrency safety in several components (origins map locking, CSRF token validation mutation locking, atomic gauge adjustments, scheduler callback snapshotting, map-copying in metrics).

Reviewed changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
web/server.go	Adds job-name validation, method checks, safer error/status handling, origins map locking, and cleanup of token/rate-limiter goroutines on shutdown.
web/middleware.go	Adds stoppable rate-limiter cleanup goroutine and documents X-Forwarded-For trust assumptions.
web/auth_secure.go	Makes CSRF validation safe for one-time-use + expiry cleanup; adds Close() to stop cleanup goroutine.
web/server_test.go	Marks many existing web server tests as parallel; updates expectations for new HTTP status semantics.
web/server_more_test.go	Aligns run/update handler expectations with new status-code behavior.
web/server_mutation_test.go	Adds validateJobName edge-case coverage.
web/server_ext_test.go	Adds coverage for CSRF/auth endpoints and method-not-allowed paths.
web/auth_secure_ext_test.go	Adds unit coverage for secure auth helpers (CSRF, token cleanup, hashing, IP parsing).
test/testutil/eventually_test.go	Adds tests for Eventually/Never helpers and error-collecting test harness behavior.
test/testlogger_test.go	Adds comprehensive tests for test logger/handler utilities.
middlewares/webhook_test.go	Adds additional table-driven coverage for webhook manager/middleware helpers.
middlewares/webhook_security_test.go	Adds coverage for additional validation branches and test override hooks.
middlewares/webhook_config_test.go	Adds coverage for config validation/default behaviors and triggers.
middlewares/slack_test.go	Adds ContinueOnStop coverage.
middlewares/save_test.go	Adds ContinueOnStop + restore/save edge-case coverage.
middlewares/sanitize_test.go	Adds package-level sanitizer function coverage.
middlewares/restore_test.go	Adds coverage for restore edge cases (skips, multi-job matching, corrupted JSON).
middlewares/preset_test.go	Adds coverage for preset loader paths (file, GitHub/url, trust matching, parsing defaults).
middlewares/preset_cache_test.go	Adds coverage for cache disk error paths and isMetaFile classification.
middlewares/overlap_test.go	Adds ContinueOnStop coverage.
middlewares/mail_test.go	Adds ContinueOnStop + additional mail/config logic coverage.
middlewares/dedup_test.go	Adds coverage for store length, init behavior, and cleanup routine.
metrics/prometheus.go	Introduces atomic gauge adjustment helper to avoid TOCTOU races for running-gauge updates.
metrics/prometheus_test.go	Adds unit coverage for RecordJobStart/Complete/Scheduled lifecycle hooks.
metrics/prometheus_ext_test.go	Adds additional edge-case coverage for job lifecycle metrics and adjustGauge behavior.
core/scheduler.go	Adds nil-safe IsRunning, improves onJobComplete callback race safety, updates concurrency comments, and enables idempotent EnableJob for already-active jobs.
core/scheduler_mutation_test.go	Extends scheduler mutation coverage (startup behavior, idempotency, stop timeout determinism, job lookup fallbacks, active/any job getters).
core/workflow_test.go	Adds edge-case coverage for workflow edge collection and wiring error classification.
core/performance_metrics.go	Avoids post-lock data races by returning copies of internal docker ops/error maps.
core/common.go	Replaces magic struct-tag string with a constant for hashing tag checks.
core/shutdown_unit_test.go	Adds unit coverage for shutdown manager + graceful server/scheduler behavior.
core/clock_unit_test.go	Adds coverage for real/fake/cron clock behavior.
core/execjob_unit_test.go	Adds unit coverage for ExecJob behavior and exit-code handling using mocks.
core/runservice_unit_test.go	Adds unit coverage for RunServiceJob behavior and error paths using mocks.
core/resilient_job_test.go	Adds coverage for resilient executor behavior (retry, rate limit, metrics recording).
core/ports/docker_test.go	Adds unit coverage for docker client option helpers.
core/domain/errors_test.go	Adds unit coverage for domain errors and helper predicates.
core/domain/event_test.go	Adds unit coverage for event helper methods.
core/domain/exec_test.go	Adds unit coverage for HijackedResponse close semantics.
core/domain/image_test.go	Adds unit coverage for repository/tag parsing behavior.
core/domain/service_test.go	Adds unit coverage for terminal task state classification.
core/adapters/docker/service_convert_test.go	Adds broad conversion coverage between domain and swarm types.
config/validator_test.go	Adds coverage for slice-field validation behavior.
cli/config_ext_test.go	Adds coverage for config build/update, glob resolution, warnings, and metadata handling.
cli/config_decode_test.go	Adds coverage for weak decode and metadata extraction/merging edge cases.
cli/config_validate_ext_test.go	Adds coverage for duration validator + error formatting branches.
cli/daemon_ext_test.go	Adds coverage for daemon option application and history restore behavior.
cli/doctor_ext_test.go	Adds coverage for doctor command checks and output formatting paths.
cli/progress_ext_test.go	Adds coverage for terminal/non-terminal progress indicator and reporter logic.

[codspeed-hq]

Merging this PR will improve performance by ×18

⚡ 1 improved benchmark
✅ 25 untouched benchmarks

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
⚡	BenchmarkExecutionMemoryWithoutPool	10,960 µs	609.9 µs	×18

---

_{Comparing feat/test-coverage-all (c664b51) with main (e1d2a36)}

[github-actions]

Automated approval for solo maintainer project

All CI checks passed. See SECURITY.md for compensating controls.

[github-actions]

🚀 Released in v0.21.0

Thank you for your contribution! 🙏

This is now available in the latest release. Please test and verify everything works as expected in your environment.

If you encounter any issues, please open a new issue.