FlashSession (KISS) #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Http/FlashSession.php
Outdated
Author
There was a problem hiding this comment.
Use uppercase for two-letter abbreviations
http://doc.nette.org/en/2.1/coding-standard#toc-common-naming-conventions
Isn't this valid? Like DI etc.
Contributor
There was a problem hiding this comment.
You should comply the framework coding standard. I bet you, that there is not a single occurence of ID, but several of Id. If you wanna change that, change it everywhere.
Author
There was a problem hiding this comment.
I don't want to debate it, was just checking if manual is up to date which it isn't.
Member
There was a problem hiding this comment.
Abbreviation should be replaced with Acronym in doc.
dg
force-pushed
the
master
branch
4 times, most recently
from
287cae9 to
f55bed2
Compare
dg
force-pushed
the
master
branch
9 times, most recently
from
0bb4336 to
96b498c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #5 (comment).